Added camera state to keep track of and handle state through rotations/backgrounding (WIP) #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devotaaabel
force-pushed
the
devota-add-camera-state
branch
from
b14e9d4 to
0e43353
Compare
devotaaabel
force-pushed
the
devota-add-camera-state
branch
from
0e43353 to
1457657
Compare
devotaaabel
force-pushed
the
devota-add-camera-state
branch
from
1457657 to
7c33a86
Compare
Contributor
Author
|
@danesfeder @Guardiola31337 Can I get some feedback on whether or not we want to go in this direction to handle camera state discrepancies? |
devotaaabel
force-pushed
the
devota-add-camera-state
branch
from
7c33a86 to
2b00f2d
Compare
devotaaabel
force-pushed
the
devota-add-camera-state
branch
from
2b00f2d to
51527ef
Compare
devotaaabel
added
the
needs discussion
Contributor
|
@devotaaabel can we follow up on this work and confirm that camera states are still not persisted through rotation? I think this may have been addressed by some of the camera work done in #1372 |
Contributor
Author
|
Closing because this is very outdated and would probably need to be re-worked from scratch if we decided to go forward with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to multiple issues in #1072