Migrate camera tracking logic to the LocationLayerPlugin #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
approved these changes
Oct 1, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
@LukasPaczos thanks for the quick work on this - the UI looks and feels much snappier with these updates. One minor comment not blocking 🚀
...n-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/map/NavigationMapboxMap.java
Show resolved
Hide resolved
danesfeder
force-pushed
the
lp-migrate-camera-tracking
branch
from
aaac778 to
923caa9
Compare
Contributor
|
@LukasPaczos going ahead and merging here, thanks Lukas! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilizes
CameraModes that come bundled with theLocationLayerPluginto handle camera tracking logic. This PR also enhances the UX when quick zooming in/out with a double tap or a two-tap by using the user location as the focal point.