Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Sep 3, 2018

Edited:

  • Bumps Location Layer Plugin version to 0.8.00.8.1

Noting that with the latest changes introduced, now you cannot use the constructor LocationLayerPlugin(@NonNull MapView mapView, @NonNull MapboxMap mapboxMap, @Nullable LocationEngine locationEngine) passing null as LocationEngine, you get the following building error:

error: reference to LocationLayerPlugin is ambiguous
both constructor LocationLayerPlugin(MapView,MapboxMap,LocationLayerOptions) in LocationLayerPlugin and constructor LocationLayerPlugin(MapView,MapboxMap,LocationEngine) in LocationLayerPlugin match

Edited:
Fixed in 0.8.1

Also, I noticed a 📉 in the performance 😭

llp_0_8_0_jumpy

0.8.0 Nexus 5 - Android 6.0

llp_0_7_1_smooth

0.7.1 Nexus 5 - Android 6.0

Note how the puck is more "jumpy" when using 0.8.0 version.

After some 🕵️ I believe this was introduced in 0.7.2 mapbox/mapbox-plugins-android#615 (noting that we didn't bump to 0.7.2, we're still using 0.7.1). I've tested the same scenario using 0.7.2 and I'm 👀 the same "jumpy" puck behavior. Could this be the reason? Would you mind helping me here @LukasPaczos @danesfeder @langsmith?

@LukasPaczos
Copy link

ezgif com-video-to-gif 5
I wasn't able to reproduce the "jumpiness". Would you be able to do some debugging on your end? check whether location udpates are provided correctly to the animator and whether LocationLayer#setLocationPoint is called with correct values?

Good catch on the constructor clash!

@Guardiola31337
Copy link
Contributor Author

"jumpiness" issue was fixed upstream mapbox/mapbox-plugins-android#641 and it's available in 0.8.1 🎉

Thanks @LukasPaczos for the quick review 🙏

Edited the title to reflect that.

@Guardiola31337 Guardiola31337 changed the title Bump Location Layer Plugin version to 0.8.0 Bump Location Layer Plugin version to 0.8.1 Sep 4, 2018
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Guardiola31337 This is good to 🚢 once updated to 0.8.1. Thanks for the quick work here

@Guardiola31337 Guardiola31337 merged commit bb1bda0 into master Sep 4, 2018
@Guardiola31337 Guardiola31337 deleted the pg-bump-llp-0.8.0 branch September 4, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants