[LLP] prevent from showing the location layer on every location update #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
ready for review
LukasPaczos
suggested changes
Sep 4, 2018
Contributor
LukasPaczos
left a comment
LukasPaczos
left a comment
There was a problem hiding this comment.
Great catch! I think it'd be cleaner to expose and use LocationLayer#isHidden flag instead of introducing a new one that tries to accomplish the same thing, or checking that flag inside of the LocationLayer.
…e - now location layer show method is called only once (when the first valid fix is received)
Guardiola31337
force-pushed
the
pg-llp-show-layer-first-valid-fix
branch
from
50c6947 to
9077d99
Compare
Contributor
Author
Yeah, that's a great idea! Thanks for the quick review here. This is ready for a second round of 👀 |
This was referenced Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix the performance 📉 shown in mapbox/mapbox-navigation-android#1252
I was able to reproduce in
master👀The idea is to call
locationLayer.show()method only once (when the first valid fix is received).Apparently, calling
show>setRenderMode>LocationLayer#styleForeground>generateBitmapmultiple times - especially when theRenderModeisGPSin whichgenerateBitmapis called 4 times - is quite heavy and has a noticeable impact on low-end devices. This was tested on a Nexus 5 running Android 6.0cc @danesfeder