Skip to content

[LLP] prevent from showing the location layer on every location update #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Guardiola31337 merged 1 commit into from
Sep 4, 2018
Merged

[LLP] prevent from showing the location layer on every location update #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...locationlayer/src/main/java/com/mapbox/mapboxsdk/plugins/locationlayer/LocationLayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ void hide() {
}
}

boolean isHidden() {
return isHidden;
}

void updateForegroundOffset(double tilt) {
JsonArray foregroundJsonArray = new JsonArray();
foregroundJsonArray.add(0f);
Expand Down
11 changes: 8 additions & 3 deletions ...onlayer/src/main/java/com/mapbox/mapboxsdk/plugins/locationlayer/LocationLayerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,9 +830,7 @@ private void updateLocation(final Location location, boolean fromLastLocation) {
return;
}

if (isEnabled && isPluginStarted) {
locationLayer.show();
}
showLocationLayerIfHidden();

if (!fromLastLocation) {
staleStateManager.updateLatestLocationTime();
Expand All @@ -844,6 +842,13 @@ private void updateLocation(final Location location, boolean fromLastLocation) {
lastLocation = location;
}

private void showLocationLayerIfHidden() {
boolean isLocationLayerHidden = locationLayer.isHidden();
if (isEnabled && isPluginStarted && isLocationLayerHidden) {
locationLayer.show();
}
}

private void updateCompassHeading(float heading) {
pluginAnimatorCoordinator.feedNewCompassBearing(heading, mapboxMap.getCameraPosition());
}
Expand Down