Skip to content

Conversation

@olegzil
Copy link
Contributor

@olegzil olegzil commented Mar 12, 2020

Description

This PR fixes Telemetry CANCEL and ARRIVAL telemetry events

Implementation

The issues had to do with job cancelation. Since the code is reactive, relies on coroutines, all long running jobs have to finish in response to a cancel or arrival event.

Testing

Pending

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Checklist

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@olegzil olegzil force-pushed the oz-telemetry-improvements branch from 16e314b to b199023 Compare March 13, 2020 01:38
…troy, fix formatting and ignore mapbox navigation tests failing because mapbox navigation telemetry calling functions are now suspendable
@Guardiola31337 Guardiola31337 force-pushed the oz-telemetry-improvements branch from 051c1c2 to 0dee863 Compare March 13, 2020 02:28
@codecov-io
Copy link

Codecov Report

Merging #2580 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2580   +/-   ##
=========================================
  Coverage     29.14%   29.14%           
  Complexity     1061     1061           
=========================================
  Files           281      281           
  Lines         10738    10738           
  Branches        871      871           
=========================================
  Hits           3130     3130           
  Misses         7265     7265           
  Partials        343      343

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going ahead and merging here @olegzil Added some TODOs, let's fix them in a separate PR.

@Guardiola31337 Guardiola31337 merged commit 407e800 into master Mar 13, 2020
@Guardiola31337 Guardiola31337 deleted the oz-telemetry-improvements branch March 13, 2020 02:40
@Guardiola31337 Guardiola31337 mentioned this pull request Jun 12, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants