Fix events generation and ingestion #2616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
topic: telemetry
Core
olegzil
force-pushed
the
pg-telemetry-events
branch
4 times, most recently
from
e7a55f7 to
dfba3e9
Compare
olegzil
approved these changes
Mar 22, 2020
olegzil
approved these changes
Mar 22, 2020
olegzil
approved these changes
Mar 22, 2020
Guardiola31337
force-pushed
the
pg-telemetry-events
branch
from
df5e2ef to
b39b41e
Compare
Guardiola31337
commented
Mar 22, 2020
| routeProgressPredicate.set { routeProgress -> beforeArrival(routeProgress) } | ||
| } | ||
|
|
||
| fun isPossibleDepartureEvent(): DirectionsRoute? = newRouteAvailable.get() |
Contributor
Author
There was a problem hiding this comment.
Function "isPossibleDepartureEvent" is never used
Guardiola31337
force-pushed
the
pg-telemetry-events
branch
from
b39b41e to
ccbabe7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2616 +/- ##
============================================
- Coverage 29.04% 29.03% -0.02%
Complexity 1062 1062
============================================
Files 281 281
Lines 10832 10837 +5
Branches 881 882 +1
============================================
Hits 3146 3146
- Misses 7340 7345 +5
Partials 346 346 |
- port legacy events - add required events fields to avoid server rejections - port schema tests - start adding proguard support Co-authored-by: oleg zilberman <oleg.zilberman@mapbox.com>
Guardiola31337
force-pushed
the
pg-telemetry-events
branch
from
ccbabe7 to
22a5015
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes events generation and ingestion - we were receiving
422errors from the server due to malformed events and some events were sent out of orderFollow up from #2445 and #2580
bug,feature,new API(s),SEMVER, etc.)Goal
Fix event telemetry
Implementation
SchemaTests@olegzil add any other relevant implementation details here 🙏
Testing
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PRcc @zugaldia @olegzil