Replay route with history player

[kmadsen]

Description

Create parity with a new interface. The new route player should behave the same as the old replay route location engine.

• I have added any issue links
• I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
• I have added the appropriate milestone and project boards

Screenshots or Gifs

old player	new player

Testing

Please describe the manual tests that you ran to verify your changes

• I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
• I have tested via a test drive, or a simulation/mock location app
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have updated the CHANGELOG including this PR

[Guardiola31337]

This is looking good @kmadsen

One thing that I noticed when testing is that it seems we're wrongly calculating the last locations in the route 👀

I believe this is related to the fact of using a constant speed to generate the points along the route geometry. We've seen this in the past when using ReplayRouteLocationEngine / ReplayRouteLocationConverter.

Refs. #2717

[kmadsen]

One thing that I noticed when testing is that it seems we're wrongly calculating the last locations in the route 👀

Yeah I made this work the same way as the existing replay engine. So the behavior is unchanged. Can get started on improving it

[kmadsen]

I am finding that simulated locations are not working well with enhanced locations. Building GPS simulated locations from a route will have a lot of effort.

Here is the video after updating the LocationComponent with RawLocations from the history player @Guardiola31337

[Guardiola31337]

@kmadsen

I am finding that simulated locations are not working well with enhanced locations.

Not sure about this as a workaround 👀

• Clients will need to add logic on their side depending on the LocationEngine used onRawLocationChanged vs onEnhancedLocationChanged
• Cutting corners when in simulation would regress 👀 Expose list of key points leading up to the enhanced location update #2452
• We're still seeing unexpected off-routes Re-routes when in simulation mode should not happen #2717

[kmadsen]

Not sure about this as a workaround 👀

If we're generating locations, I think we should be controlling the view directly. We can rely on the history data to replay GPS and real data.

Otherwise, will need some more time to see if building a location generator that is able to slow down at corners.

[kmadsen]

Closing this as it's going to go back in progress

[codecov-io]

Codecov Report

Merging #2766 into master will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2766      +/-   ##
============================================
- Coverage     35.12%   35.02%   -0.11%     
  Complexity     2100     2100              
============================================
  Files           540      541       +1     
  Lines         19260    19316      +56     
  Branches       1819     1827       +8     
============================================
  Hits           6766     6766              
- Misses        11683    11739      +56     
  Partials        811      811              

[Guardiola31337]

Left a minor comment. Other than that