Skip to content

Conversation

@kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Apr 16, 2020

Description

Starting with the minimum to add waypoint support to replay. So I can support replay waypoints #2766

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Screenshots or Gifs

use long press route all points
output output

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@kmadsen kmadsen force-pushed the km-add-waypoints-to-replay branch 3 times, most recently from d35f4e1 to 3372934 Compare April 17, 2020 00:25
@kmadsen kmadsen force-pushed the km-add-waypoints-to-replay branch from 3372934 to 0711b93 Compare April 17, 2020 00:27
@kmadsen kmadsen added this to the v1.0.0 milestone Apr 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #2786 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2786   +/-   ##
=========================================
  Coverage     35.14%   35.14%           
  Complexity     2100     2100           
=========================================
  Files           540      540           
  Lines         19260    19260           
  Branches       1819     1819           
=========================================
  Hits           6769     6769           
  Misses        11681    11681           
  Partials        810      810           

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

As you can notice 👇 notification is stuck when arriving to the first destination (You have arrived) and there's a maneuver arrow displayed (behind the notification 😅) when shouldn't cc'ing @cafesilencio as this seems a regression from NavigationMapboxMap

multi_leg_not_supported

In any case, we're able to reproduce the multi-leg issues and start tackling them 💪

@kmadsen kmadsen merged commit e57ca11 into master Apr 17, 2020
@kmadsen kmadsen deleted the km-add-waypoints-to-replay branch April 20, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants