Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

Description

Fixes Logger creation

Regression from #2820

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

https://github.com/mapbox/mapbox-navigation-android/pull/2820/files#r412584609 Logger doesn't need to take Logger as parameter (Logger is a singleton object so the module provider gets the instance this way and doesn't even reach the arguments so it doesn't crash but it's generally incorrect)
https://github.com/mapbox/mapbox-navigation-android/pull/2820/files#r412977448 reuse logger as was created before (no need to instantiate twice)

Implementation

MapboxModuleType.CommonLogger -> arrayOf()
Logger::class.java to logger

Testing

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@Guardiola31337 Guardiola31337 merged commit 881b6ba into master Apr 22, 2020
@Guardiola31337 Guardiola31337 deleted the pg-fix-logger-creation branch April 22, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants