Add internal package to libnavigation-util #2820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
✓ ready for review
backwards incompatible
JunDai
approved these changes
Apr 21, 2020
Guardiola31337
force-pushed
the
pg-1.0-internal-refactor-utils
branch
from
2874a7c to
d78a836
Compare
kmadsen
reviewed
Apr 21, 2020
| package com.mapbox.navigation.trip.notification.utils.time.span | ||
|
|
||
| internal interface SpanItem { | ||
|
|
kmadsen
approved these changes
Apr 21, 2020
Guardiola31337
force-pushed
the
pg-1.0-internal-refactor-utils
branch
3 times, most recently
from
8423f0e to
919b8a0
Compare
Guardiola31337
force-pushed
the
pg-1.0-internal-refactor-utils
branch
from
919b8a0 to
1418ecf
Compare
Guardiola31337
commented
Apr 22, 2020
Comment on lines
+558
to
+560
| Logger::class.java to MapboxModuleProvider.createModule( | ||
| MapboxModuleType.CommonLogger, | ||
| ::paramsProvider |
Contributor
Author
There was a problem hiding this comment.
Regression from #2774 cc @Lebedinsky @LukasPaczos
| NavigationOptions::class.java to navigationOptions | ||
| ) | ||
| MapboxModuleType.CommonLogger -> arrayOf() | ||
| MapboxModuleType.CommonLogger -> arrayOf(Logger::class.java to logger) |
Contributor
Author
There was a problem hiding this comment.
Regression from #2774 cc @Lebedinsky @LukasPaczos
LukasPaczos
reviewed
Apr 22, 2020
| MapboxOnboardRouterConfig::class.java to (navigationOptions.onboardRouterConfig | ||
| ?: throw RuntimeException(MAPBOX_NAVIGATION_TOKEN_EXCEPTION_ONBOARD_ROUTER)) | ||
| ?: throw RuntimeException(MAPBOX_NAVIGATION_TOKEN_EXCEPTION_ONBOARD_ROUTER)), | ||
| Logger::class.java to MapboxModuleProvider.createModule( |
There was a problem hiding this comment.
this could be Logger::class.java to logger
This was referenced Apr 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
internalpackage tolibnavigation-utilSplitting #2417 in different PRs
Follow up from #2811
As this is going to be a big refactor the plan here is to open small PRs and move stuff incrementally making the review easier. Even trying to do so this first PR included changes in 64 files (mostly moving files around)
bug,feature,new API(s),SEMVER, etc.)Goal
The goal here is to add
internalpackage to1.0modules and the APIs designed only for local usageImplementation
internalpackageinternalmodifierTesting
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PR