Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Apr 23, 2020

Description

This PR adds internal package to libnavigator and libtrip-notification

Splitting #2417 in different PRs

Refs. #2811 #2820

As this is going to be a big refactor the plan here is to open small PRs and move stuff incrementally making the review easier. Even trying to do so this first PR included changes in 35 files (mostly moving files around)

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

The goal here is to add internal package to 1.0 modules and the APIs designed only for local usage

Implementation

  • Move classes around to internal package
  • Add internal modifier
  • Fix package across codebase

Testing

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@Guardiola31337 Guardiola31337 added ✓ ready for review backwards incompatible Requires a SEMVER major version change. Core Work related to core navigation and integrations. labels Apr 23, 2020
@Guardiola31337 Guardiola31337 added this to the v1.0.0 milestone Apr 23, 2020
@Guardiola31337 Guardiola31337 self-assigned this Apr 23, 2020
@codecov-io
Copy link

Codecov Report

Merging #2836 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #2836      +/-   ##
============================================
- Coverage     35.03%   35.01%   -0.02%     
  Complexity     2107     2107              
============================================
  Files           541      541              
  Lines         19409    19409              
  Branches       1836     1836              
============================================
- Hits           6799     6796       -3     
- Misses        11796    11798       +2     
- Partials        814      815       +1     

@Guardiola31337 Guardiola31337 merged commit b6138ac into master Apr 24, 2020
@Guardiola31337 Guardiola31337 deleted the pg-internal-libnavigator-libtrip-notification branch April 24, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards incompatible Requires a SEMVER major version change. Core Work related to core navigation and integrations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants