Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resets
Navigatorwhen in onTripSession#stopand renamesDirectionsSessionshutdownAPIFixes #2769
bug,feature,new API(s),SEMVER, etc.)Goal
As
MapboxNativeNavigatorImplis a singleton (object)Navigatoris retained between sessions causing unexpected behaviors as the internal cache is not resetImplementation
resetAPI toMapboxNativeNavigatorand recreateNavigatorwhenMapboxNativeNavigatorImpl#resetMapboxDirectionsSessionshutdown API fromshutdownSessiontoshutdownTesting
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PRcc @kmadsen @cafesilencio @SiarheiFedartsou