Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Apr 29, 2020

Description

Resets route and routeBufferGeoJson as part of MapboxNativeNavigatorImpl#reset

Follow up from #2850 (comment)

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Tailwork from #2850

Implementation

override fun reset() {
    navigator = Navigator()
    route = null
    routeBufferGeoJson = null
}

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

cc @kmadsen

@Guardiola31337 Guardiola31337 added ✓ ready for review Core Work related to core navigation and integrations. labels Apr 29, 2020
@Guardiola31337 Guardiola31337 added this to the v1.0.0 milestone Apr 29, 2020
@Guardiola31337 Guardiola31337 self-assigned this Apr 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #2852 into master will increase coverage by 0.40%.
The diff coverage is 57.35%.

@@             Coverage Diff              @@
##             master    #2852      +/-   ##
============================================
+ Coverage     35.00%   35.41%   +0.40%     
+ Complexity     2107     2101       -6     
============================================
  Files           541      544       +3     
  Lines         19422    19541     +119     
  Branches       1841     1841              
============================================
+ Hits           6799     6920     +121     
+ Misses        11807    11794      -13     
- Partials        816      827      +11     

@Guardiola31337 Guardiola31337 merged commit d29aa72 into master Apr 29, 2020
@Guardiola31337 Guardiola31337 deleted the pg-reset-nn-tailwork branch April 29, 2020 02:52
@Guardiola31337 Guardiola31337 changed the title Resets route and routeBufferGeoJson as part of MapboxNativeNavigatorImpl#reset Reset route and routeBufferGeoJson as part of MapboxNativeNavigatorImpl#reset May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Work related to core navigation and integrations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants