Clean up MapboxNativeNavigator #2862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
✓ ready for review
Core
kmadsen
reviewed
Apr 29, 2020
|
|
||
| @Test | ||
| fun jobCountValidationNonUIScope() = coroutineRule.runBlockingTest { | ||
| fun jobCountValidationNonUIScope() { |
Contributor
There was a problem hiding this comment.
maybe this test should actually use coroutineRule.runBlockingTest
since it delays inside
Contributor
Author
There was a problem hiding this comment.
Nah that's what I was saying here #2839 (comment) It actually makes the test execution slower so I reverted 😉
kmadsen
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up
MapboxNativeNavigatorFollow up from #2839 (comment) and #2852
Refs. #2855 and #2787
bug,feature,new API(s),SEMVER, etc.)Goal
General cleanup
Implementation
coroutineRule.runBlockingTestinThreadControllerTestnot needed (was increasing the test execution time unnecessarily)routeIndexfromMapboxNativeNavigator#setRouteas multiple routes is not supportedevery { context.unregisterReceiver(any()) } answers {}fromMapboxHybridRouterTestTesting
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PRcc @kmadsen @cafesilencio