-
Notifications
You must be signed in to change notification settings - Fork 319
Add ability to observe arrival independently #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadsen
commented
Apr 29, 2020
libnavigation-core/src/main/java/com/mapbox/navigation/core/stops/ArrivalProgressObserver.kt
Show resolved
Hide resolved
af17faf to
46ff13b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2855 +/- ##
============================================
+ Coverage 35.41% 35.43% +0.02%
- Complexity 2101 2103 +2
============================================
Files 544 545 +1
Lines 19541 19555 +14
Branches 1841 1842 +1
============================================
+ Hits 6920 6929 +9
- Misses 11794 11800 +6
+ Partials 827 826 -1 |
libnavigation-core/src/main/java/com/mapbox/navigation/core/MapboxNavigation.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/MapboxNavigation.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/MapboxNavigation.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/stops/ArrivalProgressObserver.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/stops/ArrivalController.kt
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/stops/ArrivalProgressObserver.kt
Show resolved
Hide resolved
b9e223b to
382e05e
Compare
9 tasks
Guardiola31337
approved these changes
Apr 29, 2020
libnavigation-core/src/main/java/com/mapbox/navigation/core/stops/ArrivalController.kt
Outdated
Show resolved
Hide resolved
daea56f to
ece0c30
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently finished controlling arrival #2787
But have noticed that we still want the ability to "observe" arrival, without needing to change the behavior. This pull request adds the ability to add/remove arrival observers.
bug,feature,new API(s),SEMVER, etc.)Testing
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PR