[Android Auto] Fix compatiblity issue with 2.10.0-beta.3 #6714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadsen
added
the
Android Auto
kmadsen
force-pushed
the
km-fix-upgrade-compatibility
branch
from
477b12e to
b9e57b1
Compare
kmadsen
changed the title
kmadsen
commented
Dec 11, 2022
| import androidx.car.app.navigation.model.Step | ||
| import com.mapbox.navigation.ui.maneuver.api.MapboxLaneIconsApi | ||
| import com.mapbox.navigation.ui.maneuver.api.MapboxManeuverApi | ||
| import com.mapbox.navigation.utils.internal.ifNonNull |
Contributor
Author
There was a problem hiding this comment.
this is unrelated but i searched for other internal imports and found this. unlikely this api will change but this function is not needed here anyways.
I'd like to add a linter for making sure no internal apis are used from the sdk, but haven't gotten around to it
Contributor
Author
|
|
Codecov Report
@@ Coverage Diff @@
## main #6714 +/- ##
=========================================
Coverage 72.50% 72.50%
Complexity 5510 5510
=========================================
Files 772 772
Lines 29891 29891
Branches 3529 3529
=========================================
Hits 21673 21673
Misses 6806 6806
Partials 1412 1412 |
Guardiola31337
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In androidauto-v0.14.0 we added a reference to a new internal logger https://github.com/mapbox/mapbox-navigation-android/pull/6429/files#diff-2b11dc16c8381b48dcd005d941a0caf38d9fc488c65572d18f242e69b76fce3fR82
in navsdk 2.10.0-beta-3 we fixed an issue with that new internal logger using an api change that is not backwards compatible https://github.com/mapbox/mapbox-navigation-android/pull/6704/files#diff-7644c4d71ba636edcf531827e66e8b86febc6b98885ace62d7a676e275de1457L5
Essentially, androidauto-v0.14.0+ will not be compatible with 2.10-beta-3. This pull request is to make it so we can have a new release of androidauto-v0.18.1 that will be compatible with 2.10-beta-3+.
The fix is to not use the new lazy logger yet.
More details
Internal apis are not verified as being backwards compatible so this issue is not caught pre-release. We have also recently started with androidauto automated tests that will catch this type of issue. We have also not yet started the stable/beta android auto release channels so we are not yet releasing with 2.10-beta. How we have been supporting "upgradability" (allowing old versions of androidauto to use new versions of navsdk) is by only using backwards compatible apis (public semver protected). There is still one exception, the internal logging tool 😅. We may remove the internal logger from ui-androidauto for this reason.