Skip to content

Conversation

@kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Dec 15, 2022

Description

The example repository has an example that can maintain the latest final versions. https://github.com/mapbox/mapbox-navigation-android-examples/tree/main/android-auto-app

This repository is where development happens, so it makes sense to ensure the latest versions are working together. It also makes it possible for us to test some of the latest changes. ReplayRouteSession is one example so adding it here.

There was also an incompatibility with 2.10.0-beta.3 that has been fixed. I think this project could be a good place to catch those issues earlier #6714

@kmadsen kmadsen added the Android Auto Bugs, improvements and feature requests on Android Auto. label Dec 15, 2022
}
}
private val mapboxNavigation by requireMapboxNavigation()
private val replayRouteSession = ReplayRouteSession()
Copy link
Contributor Author

@kmadsen kmadsen Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DropInUi also includes an instance of this object so there can be odd behavior depending on which system is managing the replay trip session.

There is a plan to make it so this system can be shared but it has not been built yet https://mapbox.atlassian.net/browse/NAVAND-652

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #6753 (e5f85c2) into main (c8bc7ab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6753   +/-   ##
=========================================
  Coverage     72.54%   72.54%           
  Complexity     5521     5521           
=========================================
  Files           772      772           
  Lines         29888    29888           
  Branches       3531     3531           
=========================================
  Hits          21682    21682           
  Misses         6793     6793           
  Partials       1413     1413           

@kmadsen kmadsen force-pushed the km-upgrade-aa-to-2.10 branch from 91f1b9a to e601336 Compare December 16, 2022 17:27
@kmadsen kmadsen added the skip changelog Should not be added into version changelog. label Dec 16, 2022
@tomaszrybakiewicz
Copy link
Contributor

tomaszrybakiewicz commented Dec 16, 2022

@kmadsen How can I test this?
I ran the android-auto-app, started the head unit server in Android Auto App, and ran make car.
App successfully launched both on my phone and in Desktop Head Unit, but I cannot set a destination on the phone, nor via search in AA.
What am I doing wrong?

@kmadsen
Copy link
Contributor Author

kmadsen commented Dec 16, 2022

I ran the android-auto-app, started the head unit server in Android Auto App, and ran make car.
App successfully launched both on my phone and in Desktop Head Unit, but I cannot set a destination on the phone, nor via search in AA.
What am I doing wrong?

Yeah you found an issue with CarAppSyncComponent where we try to sync state between DropInUi and AndroidAuto.

Pushed a fix. Also here is to update the example repo mapbox/mapbox-navigation-android-examples#176

@kmadsen kmadsen enabled auto-merge (squash) December 16, 2022 22:05
@kmadsen kmadsen merged commit cf4c8ea into main Dec 16, 2022
@kmadsen kmadsen deleted the km-upgrade-aa-to-2.10 branch December 16, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Auto Bugs, improvements and feature requests on Android Auto. skip changelog Should not be added into version changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants