-
Notifications
You must be signed in to change notification settings - Fork 319
[Android Auto] Bump example to 2.10 #6753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
| } | ||
| private val mapboxNavigation by requireMapboxNavigation() | ||
| private val replayRouteSession = ReplayRouteSession() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DropInUi also includes an instance of this object so there can be odd behavior depending on which system is managing the replay trip session.
There is a plan to make it so this system can be shared but it has not been built yet https://mapbox.atlassian.net/browse/NAVAND-652
Codecov Report
@@ Coverage Diff @@
## main #6753 +/- ##
=========================================
Coverage 72.54% 72.54%
Complexity 5521 5521
=========================================
Files 772 772
Lines 29888 29888
Branches 3531 3531
=========================================
Hits 21682 21682
Misses 6793 6793
Partials 1413 1413 |
91f1b9a to
e601336
Compare
|
@kmadsen How can I test this? |
Yeah you found an issue with Pushed a fix. Also here is to update the example repo mapbox/mapbox-navigation-android-examples#176 |
Description
The example repository has an example that can maintain the latest final versions. https://github.com/mapbox/mapbox-navigation-android-examples/tree/main/android-auto-app
This repository is where development happens, so it makes sense to ensure the latest versions are working together. It also makes it possible for us to test some of the latest changes.
ReplayRouteSessionis one example so adding it here.There was also an incompatibility with 2.10.0-beta.3 that has been fixed. I think this project could be a good place to catch those issues earlier #6714