Explicitly guarantee the order or route progress during reroute #6764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6764 +/- ##
=========================================
Coverage 72.50% 72.50%
Complexity 5528 5528
=========================================
Files 774 774
Lines 29950 29950
Branches 3540 3540
=========================================
Hits 21714 21714
Misses 6814 6814
Partials 1422 1422 |
VysotskiVadim
force-pushed
the
NAVAND-1027-guaranteed-order-of-events
branch
from
ed1f19c to
0fc99a8
Compare
dzinad
approved these changes
Dec 20, 2022
...igation-core/src/main/java/com/mapbox/navigation/core/reroute/NavigationRerouteController.kt
Outdated
Show resolved
Hide resolved
Closed
This was referenced Jan 5, 2023
This was referenced Jan 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not so easy to implement switching to an alternative route during reroute in a way the SDK does it internally. Internally we access the latest route progress from the trip session, but external users can't do it, they have to combine route progress and reroute events. It would be easier to combine SDK can provide some guarantees about the order.
See more details in NAVAND-1027
Alternative approach to solve the problem could be found here: #6765