Navigation Reroute controller V2 [In progress]

[VysotskiVadim]

This PR solves exactly the same problem as #6764

I think that the SDK should provide all the needed data inside the reroute event so that users don't need to combine route progress and reroute events.

To support reroute parameters, I had to introduce a new interface.

[dzinad]

Left some comments but I like the approach from #6764 more for reasons specified in the ticket.

[dzinad]

Why?

[dzinad]

Should we deprecate the old reroute method? And the interface? Because now it's not very clear how the user would implement the old reroute method. They'll still have to search for relevant request data on their own. With the deprecation it becomes clear that the old method will not be called for NavigationRerouteControllerV2.

[VysotskiVadim]

The SDK users may have mapboxNavigation.reroute() calls in their code. I don't know why they might want to call it, but they can, and if they switch to NavigationRerouteControllerV2 without implementing old reroute, this case may be broken.

[dzinad]

MapboxNavigation#reroute is private, they can't invoke it.

[VysotskiVadim]

sorry, I meant mapboxNavigaiton.getRerouteController()?.reroute()

[dzinad]

But if they invoke it then they have it implemented. Nothing will break here.
However, why should all the users that don't invoke reroute directly implement it? If they use NavigationRerouteControllerV2 they will probably want to receive request data as arguments. What would they do for the old reroute method? Would they just ignore the case with switching to alternatives? Or get the data themselves via RouteProgressObserver? But if we deprecate it with a message that says that we won't invoke it, they won't have to implement it at all. If they invoke it somewhere in their code - let them implement it. I don't see what exactly would break here.

[codecov]

Codecov Report

Merging #6765 (bcea879) into main (cf4c8ea) will increase coverage by 0.01%.
The diff coverage is 90.90%.

@@             Coverage Diff              @@
##               main    #6765      +/-   ##
============================================
+ Coverage     72.49%   72.50%   +0.01%     
- Complexity     5522     5524       +2     
============================================
  Files           772      774       +2     
  Lines         29924    29949      +25     
  Branches       3535     3536       +1     
============================================
+ Hits          21694    21716      +22     
- Misses         6814     6816       +2     
- Partials       1416     1417       +1     

Impacted Files	Coverage Δ
...re/reroute/NavigationRerouteControllerV2Adapter.kt	71.42% <71.42%> (ø)
...ava/com/mapbox/navigation/core/MapboxNavigation.kt	71.16% <85.71%> (+0.11%)	⬆️
...navigation/core/reroute/MapboxRerouteController.kt	92.25% <95.45%> (+0.22%)	⬆️
...tion/core/reroute/NavigationRerouteControllerV2.kt	100.00% <100.00%> (ø)

[VysotskiVadim]

It feels that new reroute controller interface brings more confusion than value.