Sb cherry pick pr 6466 #6816
Merged
Sb cherry pick pr 6466 #6816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zayankovsky
reviewed
Jan 10, 2023
CHANGELOG.md
Outdated
| - :warning: Updated the `NavigationView` default navigation puck asset. [#6678](https://github.com/mapbox/mapbox-navigation-android/pull/6678) | ||
|
|
||
| Previous puck can be restored by injecting `LocationPuck2D` with the `bearingImage` set to `com.mapbox.navigation.ui.maps.R.drawable.mapbox_navigation_puck_icon` drawable: | ||
| ```kotlin | ||
| navigationView.customizeViewStyles { | ||
| locationPuckOptions = LocationPuckOptions.Builder(context) | ||
| .defaultPuck( | ||
| LocationPuck2D( | ||
| bearingImage = ContextCompat.getDrawable( | ||
| context, | ||
| com.mapbox.navigation.ui.maps.R.drawable.mapbox_navigation_puck_icon, | ||
| ) | ||
| ) | ||
| ) | ||
| .idlePuck(regularPuck(context)) | ||
| .build() | ||
| } | ||
| ``` | ||
| - Added guarantees that route progress with `RouteProgress#currentState == OFF_ROUTE` arrives earlier than `NavigationRerouteController#reroute` is called. [#6764](https://github.com/mapbox/mapbox-navigation-android/pull/6764) | ||
| - Fixed a rare `java.lang.NullPointerException: Attempt to read from field 'SpeechAnnouncement PlayCallback.announcement' on a null object reference` crash in `PlayCallback.getAnnouncement`. [#6760](https://github.com/mapbox/mapbox-navigation-android/pull/6760) | ||
| - Fixed standalone `MapboxManeuverView` appearance when the app also integrates Drop-In UI. [#6774](https://github.com/mapbox/mapbox-navigation-android/pull/6774) | ||
| - Introduced `NavigationViewListener.onSpeedInfoClicked` that would be triggered when `MapboxSpeedInfoView` is clicked upon. [#6770](https://github.com/mapbox/mapbox-navigation-android/pull/6770) | ||
| - Each newly instantiated MapboxRouteArrowView class will initialize the layers with the provided options on the first render call. Previously this would only be done if the layers hadn't already been initialized. [#6466](https://github.com/mapbox/mapbox-navigation-android/pull/6466) |
Contributor
There was a problem hiding this comment.
Just like in #6815 (comment) you have to clean up the changelog. That always happens with cherry-picks, but that won't be an issue once we adopt the new changelog strategy by @SevaZhukov.
Author
There was a problem hiding this comment.
This will lead to a conflict and a rebase will create a mess just like the last one. Here we go...
Author
There was a problem hiding this comment.
Fortunately no conflict this time.
Codecov Report
@@ Coverage Diff @@
## release-v2.10 #6816 +/- ##
================================================
Coverage 72.54% 72.54%
- Complexity 5521 5525 +4
================================================
Files 772 772
Lines 29894 29903 +9
Branches 3533 3533
================================================
+ Hits 21686 21693 +7
- Misses 6793 6794 +1
- Partials 1415 1416 +1
|
cafesilencio
force-pushed
the
sb-cherry-pick-pr-6466-v2
branch
from
fe7ad7d to
0db701b
Compare
Zayankovsky
approved these changes
Jan 10, 2023
Comment on lines
8
to
9
| - Fixed an issue with `NavigationView` that caused info panel to shrink in landscape mode with a full screen theme. [#6811](https://github.com/mapbox/mapbox-navigation-android/pull/6811) | ||
| - Fixed standalone `MapboxManeuverView` appearance when the app also integrates Drop-In UI. [#6810](https://github.com/mapbox/mapbox-navigation-android/pull/6810) |
Contributor
There was a problem hiding this comment.
These 2 lines need to be restored, those are the changes that I cherry-picked.
…oved so that new options will take effect. (#6466) Co-authored-by: Seth Bourget <seth@cafesilencio.net>
cafesilencio
force-pushed
the
sb-cherry-pick-pr-6466-v2
branch
from
0db701b to
349ca99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick of PR 6466.
Screenshots or Gifs