When initialize layers methods are called the existing layers are rem… #6815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added QA-Test-App “use legacy puck” toggle. Updated navigation puck vector drawable. CHANGELOG entry Updated navigation puck asset. Added NavPuck spinner to QA-Test-App. More changes to puck asset Using RenderScript to apply blurred shadow to new navigation puck.
* [Android Auto] Bump example to 2.10 * Fix app set destination issue
…oved so that new options will take effect. (#6466) Co-authored-by: Seth Bourget <seth@cafesilencio.net>
… change before voice instructions (#6766)
* fix info panel dimensions in landscape with a full screen theme * Rename changelog files Co-authored-by: runner <runner@fv-az308-698>
…T and “skip changelog” labelled PRs. (#6781) * Updated rename_changelog_file.py script to account for DRAFT and “skip changeling” labeled PRs. * Use GitHub Action expression to filter out PR that are labeled ‘skip changelog’. * Using only GitHub Action expressions. Rolledback changes to scripts..github/workflows/rename_changelog_file.yml
…r`: (#6638) * Move `fetchRouteIfNeeded` to `RoutePreviewStateController`: - Moved RouteOptionsProvider to SharedApp to allow its injection to RoutePreviewStateController. - Introduced FetchRouteAndShowRoutePreview and FeetchRouteAndStartActivenNavigation actions. - Removed fetchRouteAnd** thunk actions (replaced by the above) - Moved fetch route and start preview/active nav. processing to RoutePreviewStateController - Renamed FetchOptions -> FetchRoute action. - Updated RoutePreviewStateController to directly use RouteOptionsProvider to generate necessary RouteOptions for fetch route request. addressing PR review comments * Unit tests fix.
Co-authored-by: root <root@2a997c30c396>
Co-authored-by: root <root@20a03daa94df>
Co-authored-by: root <root@20a03daa94df>
* Increased InfoPanel bottom guideline max pos to 50% of the NavigationView height and made it customizable via ViewStyleCustomization.infoPanelGuidelineMaxPosPercent. * CHANGELOG entry * Rename changelog files Co-authored-by: runner <runner@fv-az465-655>
Codecov Report
@@ Coverage Diff @@
## release-v2.10 #6815 +/- ##
===================================================
- Coverage 72.54% 72.54% -0.01%
+ Complexity 5522 5521 -1
===================================================
Files 772 772
Lines 29899 29894 -5
Branches 3533 3533
===================================================
- Hits 21691 21686 -5
Misses 6793 6793
Partials 1415 1415
|
cafesilencio
force-pushed
the
sb-cherrypick-pr-6466
branch
from
97483a2 to
b8595b3
Compare
abhishek1508
approved these changes
Jan 10, 2023
…oved so that new options will take effect. (#6466) Co-authored-by: Seth Bourget <seth@cafesilencio.net>
cafesilencio
force-pushed
the
sb-cherrypick-pr-6466
branch
from
b8595b3 to
5fbe924
Compare
Zayankovsky
requested changes
Jan 10, 2023
Contributor
Zayankovsky
left a comment
Zayankovsky
left a comment
There was a problem hiding this comment.
Something went wrong with the rebase, there are a lot of unrelated changes now.
Author
|
Yep, it's a mess. |
Author
|
I'm going to close this and try again. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick of PR 6466.
Screenshots or Gifs