Skip to content

Conversation

@Zayankovsky
Copy link
Contributor

@Zayankovsky Zayankovsky commented Jan 18, 2023

Description

Removed extra CoordinatorLayout with fitsSystemWindows and set paddings according to the current insets manually. The issue with fitsSystemWindows is that it also reacts to keyboard insets, while NavigationViewContext.systemBarsInsets only contains system bar insets. This leads to inconsistencies, e.g. when keyboard is shown the road name view will end up at the top of the screen despite the 50% guideline top position limitation we have.

Before:

before.mp4

After:

after.mp4

@Zayankovsky Zayankovsky added bug Defect to be fixed. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. labels Jan 18, 2023
@Zayankovsky Zayankovsky self-assigned this Jan 18, 2023
@github-actions
Copy link

github-actions bot commented Jan 18, 2023

Changelog

Features

  • Added MapboxTripStarter to simplify the solution for managing the trip session and replaying routes. This also makes it possible to share the replay state between drop-in-ui and android-auto. #6794

Bug fixes and improvements

  • Removed NavigationRoute#hasUnexpectedClosures and added RouteProgress#hasUnexpectedUpcomingClosures instead that checks whether route has upcoming unexpected closures (the algorithm does not take into account closures that the puck has already been on) #6841
  • Improved NavigationView camera behavior to go back into overview state if routes change during route preview state. #6840
  • Improved NavigationView camera behavior to ignore keyboard insets. #6845

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

@Zayankovsky Zayankovsky force-pushed the vz-NAVAND-1069 branch 2 times, most recently from 39a53ca to bd5c950 Compare January 19, 2023 11:58
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #6845 (9274508) into main (ce11135) will decrease coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #6845      +/-   ##
============================================
- Coverage     72.65%   72.63%   -0.03%     
+ Complexity     5565     5561       -4     
============================================
  Files           781      781              
  Lines         30128    30113      -15     
  Branches       3562     3555       -7     
============================================
- Hits          21890    21873      -17     
- Misses         6815     6817       +2     
  Partials       1423     1423              
Impacted Files Coverage Δ
...avigation/dropin/infopanel/InfoPanelCoordinator.kt 66.95% <66.66%> (-1.74%) ⬇️
...ava/com/mapbox/navigation/dropin/NavigationView.kt 97.26% <100.00%> (ø)
...x/navigation/dropin/camera/CameraLayoutObserver.kt 91.17% <100.00%> (-2.71%) ⬇️
...pin/internal/extensions/NavigationViewContextEx.kt 93.16% <100.00%> (ø)
.../com/mapbox/navigation/dropin/map/MapViewBinder.kt 97.05% <100.00%> (ø)

Copy link
Contributor

@tomaszrybakiewicz tomaszrybakiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhishek1508
Copy link
Contributor

Running this branch I am seeing issue with the puck which hides beneath road name view in portrait mode and it is cut in the landscape mode

Record_2023-01-19-12-23-17.mp4

@Zayankovsky

@Zayankovsky
Copy link
Contributor Author

Running this branch I am seeing issue with the puck which hides beneath road name view in portrait mode and it is cut in the landscape mode

This should be fixed now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Defect to be fixed. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants