-
Notifications
You must be signed in to change notification settings - Fork 319
ignore ime insets in navigation view #6845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ChangelogFeatures
Bug fixes and improvements
Known issues
|
39a53ca to
bd5c950
Compare
Codecov Report
@@ Coverage Diff @@
## main #6845 +/- ##
============================================
- Coverage 72.65% 72.63% -0.03%
+ Complexity 5565 5561 -4
============================================
Files 781 781
Lines 30128 30113 -15
Branches 3562 3555 -7
============================================
- Hits 21890 21873 -17
- Misses 6815 6817 +2
Partials 1423 1423
|
tomaszrybakiewicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Running this branch I am seeing issue with the puck which hides beneath road name view in portrait mode and it is cut in the landscape mode Record_2023-01-19-12-23-17.mp4 |
bd5c950 to
6bb4ed5
Compare
This should be fixed now, thanks. |
6bb4ed5 to
9274508
Compare
Description
Removed extra
CoordinatorLayoutwithfitsSystemWindowsand set paddings according to the current insets manually. The issue withfitsSystemWindowsis that it also reacts to keyboard insets, whileNavigationViewContext.systemBarsInsetsonly contains system bar insets. This leads to inconsistencies, e.g. when keyboard is shown the road name view will end up at the top of the screen despite the 50% guideline top position limitation we have.Before:
before.mp4
After:
after.mp4