Check for valid BannerInstructions when milestones are enabled #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
force-pushed
the
dan-null-banner-voice
branch
from
9eaf8a2 to
7dfc5da
Compare
Guardiola31337
approved these changes
May 15, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Minor comments not blocking the PR.
Good job @danesfeder
| @Test(expected = MissingFormatArgumentException.class) | ||
| public void validDirectionsRoute_isInvalidWithNullRouteOptions() throws Exception { | ||
| DirectionsRoute route = buildTestDirectionsRoute(DIRECTIONS_WITHOUT_VOICE_INSTRUCTIONS); | ||
| route = route.toBuilder().routeOptions(null).build(); |
Contributor
There was a problem hiding this comment.
What about extracting the null into an explaining variable to make clear what we're specifically testing?
|
|
||
| @Test(expected = MissingFormatArgumentException.class) | ||
| public void validDirectionsRoute_isInvalidWithNullInstructions() throws Exception { | ||
| DirectionsRoute route = buildRouteWithNullInstructions(); |
Contributor
There was a problem hiding this comment.
What about renaming route to make clear what we're specifically testing?
|
|
||
| @Test(expected = MissingFormatArgumentException.class) | ||
| public void validDirectionsRoute_isInvalidWithFalseVoiceInstructions() throws Exception { | ||
| DirectionsRoute route = buildRouteWithFalseVoiceInstructions(); |
|
|
||
| @Test(expected = MissingFormatArgumentException.class) | ||
| public void validDirectionsRoute_isInvalidWithFalseBannerInstructions() throws Exception { | ||
| DirectionsRoute route = buildRouteWithFalseBannerInstructions(); |
danesfeder
force-pushed
the
dan-null-banner-voice
branch
2 times, most recently
from
ce54d52 to
6466f28
Compare
Contributor
Author
danesfeder
force-pushed
the
dan-null-banner-voice
branch
from
6466f28 to
9b3b5e6
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If default milestones are enabled (
Voice/Bannerinstructions), we need to check for both in theRouteOptionsbefore we proceed with processing. We are currently only checking for voice.