Switching all plugins to AndroidX #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Close to ✅ Current 💥 is about Running Need to hunt down the right place to adjust the scripting so that AndroidX lines are used instead |
langsmith
force-pushed
the
ls-refactor-to-androidx
branch
from
7efecf0 to
139bbd2
Compare
Contributor
Author
|
CI is passing. Next step for me is to do manual QA of all plugins in this repo's test app. |
langsmith
changed the title
Contributor
Author
|
All plugins are working as expected in the test app on this branch. We're good to go here @tobrun . |
langsmith
added
the
ready for review
This was referenced Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr switches this repo's plugins and related files to AndroidX.
These changes follow the
9.0.0Maps SDK release, which introduced AndroidX in https://github.com/mapbox/mapbox-gl-native-android/pull/129/files and went out in https://github.com/mapbox/mapbox-gl-native-android/releases/tag/android-v9.0.0-alpha.1The Java SDK switch to AndroidX happened at mapbox/mapbox-java#1095 and went out in the
5.0.0release: https://github.com/mapbox/mapbox-java/releases/tag/v5.0.0