Filter location updates and remove unused animator code #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
the
location-layer-plugin
LukasPaczos
approved these changes
Mar 30, 2018
|
Hi, |
Contributor
|
@vicolmoldoveanu this should enhance user experience even more, but please try This PR will ship with the upcoming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animation jank was occurring when the
LocationEnginewould push 2 or 3 updates a second (because we cancel the animation when we receive and update for a new one).This PR filters updates, limiting to only 1 per second.
Also removed animator code that is unused.