Fix LocationLayerAnimator ignored updates for first second #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
bug
cammace
approved these changes
Apr 6, 2018
cammace
left a comment
cammace
left a comment
There was a problem hiding this comment.
Noticed this as well, thanks for fixing so quickly
This was referenced Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing delays of the LLP drawing the user icon in the Navigation SDK.
The
LocationLayerAnimatorwas ignoring updates for the first second because thelocationUpdateTimeStampwasn't being set. This PR checks for invalid updates only after the first timestamp has been set.Regression from #393
cc @tobrun