remove support library and use just livedata dependency #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
added
the
location-layer-plugin
tobrun
approved these changes
Apr 10, 2018
This was referenced Apr 16, 2018
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #417
In the Location Layer Plugin, we were carrying in all of AppCompat7 which wasn't necessary since it was only being used for lifecycle events. Instead, we just need to use the
livedatadependency offered. This PR fixes this.@ivovandongen I briefly remember you mentioning you had issues adding the plugin because you also had to add the architecture sdk, would this fix it? At the very least, you won't have to exclude libraries anymore from this plugin.