Remove invalid Location update check #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
bug
LukasPaczos
reviewed
Apr 17, 2018
Contributor
LukasPaczos
left a comment
LukasPaczos
left a comment
There was a problem hiding this comment.
🚀
https://github.com/mapbox/mapbox-plugins-android/pull/431/files#diff-48f235f3a5de6e2d532243707239246aR23
should be unused now, can we get rid of it as well?
Contributor
Author
|
@LukasPaczos yep, good catch - updated |
LukasPaczos
approved these changes
Apr 17, 2018
Contributor
|
Also noting, that users should default to |
11 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that the invalid update check was causing the initial delay when showing the user's location with the
LocationLayerPlugin.After further testing, it doesn't seem the check is necessary as
LocationAPIs should not be sending the same update in less that a seconds time.