Initialize with default modes and fix style reloading issue #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
bug
tobrun
approved these changes
Apr 23, 2018
LukasPaczos
reviewed
Apr 23, 2018
|
|
||
| void initializeComponents(LocationLayerOptions options) { | ||
| prepareLocationSource(); | ||
| addLocationSource(); |
Contributor
There was a problem hiding this comment.
This change adds the source before the first location fix is available, resulting in a puck being at null island until we get the first fix instead of being invisible.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #457, Closes #456
Adds default render / camera mode when the plugin is initialized.
Fixes issue where we weren't re-adding the sources when a new style was loaded (adds test functionality to test app as well from options menu)