fix source missing when styles reloaded #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
added
the
location-layer-plugin
Guardiola31337
force-pushed
the
cam-fix-source-missing-style-reload
branch
from
0231dba to
1b35a00
Compare
Author
|
I've reopened the original ticket which brings back the null island issue but IMO, it's a much better issue then the location source not getting added correctly. Therefore, this PR has reverted back to the original logic for the 0.5.1 release and I'll look more into it after the release in a separate PR. |
cammace
added
ready for review
cammace
force-pushed
the
cam-fix-source-missing-style-reload
branch
from
d386288 to
b35e08b
Compare
tobrun
approved these changes
May 8, 2018
This was referenced May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #470
Still results in an issue when the user locations null still -> map style changes -> source gets added and location icons shown at "null island" (coordinates 0,0). Will look into fixing this before merging.