Update LocationLayerPlugin permission annotations #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
the
location-layer-plugin
cammace
suggested changes
May 19, 2018
| mapView.removeOnMapChangedListener(onMapChangedListener); | ||
| } | ||
|
|
||
| void onLocationLayerStart() { |
There was a problem hiding this comment.
Any reason for changing the access modifiers here? Changing to private causes a synthetic accessor method to be created. In my opinion, it should be the opposite, we should prevent synthetic accessor methods from being created everywhere possible as this adds to the method count.
Contributor
Author
danesfeder
force-pushed
the
dan-remove-permission
branch
from
76fb496 to
3ff71a0
Compare
|
Not sure why it would since the engine is internal, none of the public APIs are changed. |
cammace
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underlying code working with
LocationEnginein theLocationLayerPluginwas updated, but the methods annotating the required permissions for certain methods were not. These changes rearrange the annotations to reflect the new code changes.