Adds constructor which doesn't take in a locationEngine #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
added
the
ready for review
LukasPaczos
suggested changes
May 22, 2018
Contributor
LukasPaczos
left a comment
LukasPaczos
left a comment
There was a problem hiding this comment.
Thanks for running with this one @cammace, looks great so far!
We should also reset the usingInternalLocationEngine flag and deactivate/cleanup internal engine when the engine is set by the user with #setLocationEngine.
Author
|
Great point @LukasPaczos, will make the fix |
tobrun
approved these changes
May 23, 2018
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #523
Closes #524
If this constructor's used, we create a location engine and internally use it.