Skip to content

Initialize LocationEngine for all constructors if null #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danesfeder wants to merge 1 commit into from
Closed

Initialize LocationEngine for all constructors if null #539

danesfeder wants to merge 1 commit into from

Conversation

@danesfeder
Copy link
Contributor

@danesfeder danesfeder commented May 24, 2018

Re: #510 (comment)

If we only want the constructor added in #527 to initialize a default LocationEngine, then we should mark the other constructor LocationEngine params as @NonNull currently marked as nullable.

Happy to change the annotations or use the code I submitted originally

@danesfeder danesfeder added the location-layer-plugin Issues that deal with the location layer module label May 24, 2018
@danesfeder danesfeder self-assigned this May 24, 2018
@danesfeder danesfeder requested review from LukasPaczos and cammace May 24, 2018 19:22
@danesfeder danesfeder changed the title Initialize LocationEngine for all constructors Initialize LocationEngine for all constructors if null May 24, 2018
@danesfeder danesfeder mentioned this pull request May 24, 2018
Closed
@LukasPaczos
Copy link
Contributor

LukasPaczos commented May 25, 2018

The nullable LocationEngine option is there for users how would like to rely on pushing location updates via the force option, without any kind of LocationEngine at all. Personally I feel like it needs to stay, but maybe we could adjust the docs to highlight possible scenarios?

@danesfeder
Copy link
Contributor Author

danesfeder commented May 25, 2018

Ah yeah @LukasPaczos, thanks for the clarification there. Yeah an update to the docs specifying this should help

@danesfeder danesfeder closed this May 25, 2018
@danesfeder danesfeder deleted the dan-fix-engine-init branch May 25, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cammace cammace Awaiting requested review from cammace

@LukasPaczos LukasPaczos Awaiting requested review from LukasPaczos

Assignees

@danesfeder danesfeder

Labels

location-layer-plugin Issues that deal with the location layer module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danesfeder @LukasPaczos