Few improvements to traffic plugin #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
added
enhancement
ready for review
tobrun
reviewed
Jul 18, 2017
| } | ||
| } | ||
| } | ||
| return belowLayer; |
Member
There was a problem hiding this comment.
+ private String getIdLayerBelow() {
+ if (belowLayer == null || belowLayer.isEmpty()) {
+ List<Layer> styleLayers = mapboxMap.getLayers();
Layer layer;
+ for (int i = styleLayers.size() - 1; i >= 0; i--) {
layer = styleLayers.get(i);
+ if (!(layer instanceof SymbolLayer)) {
+ return layer.getId();
+ }
+ }
+ }
+ return belowLayer;
tobrun
approved these changes
Jul 18, 2017
Member
tobrun
left a comment
tobrun
left a comment
There was a problem hiding this comment.
one nit, looking good otherwise 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60
Closes #55
Closes #14?
I've gone ahead and made a few changes to the traffic plugin to keep consistency across plugins and increase compatibility to all Mapbox map styles. Only issue we should resolve (@tobrun mentioned there's a better way to do this) is to change
if (!(styleLayers.get(i) instanceof SymbolLayer))into something more performant.