Skip to content

Maps SDK v7.4.0 #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukasPaczos merged 2 commits into from
May 22, 2019
Merged

Maps SDK v7.4.0 #923

LukasPaczos merged 2 commits into from
May 22, 2019

Conversation

@langsmith
Copy link
Contributor

@langsmith langsmith commented Apr 10, 2019 •
edited
Loading

  • v7.4.0-alpha.1
  • v7.4.0-alpha.2
  • v7.4.0-beta.1
  • v7.4.0

@langsmith langsmith self-assigned this Apr 10, 2019
@langsmith
Copy link
Contributor Author

langsmith commented Apr 10, 2019

They're not specific to 7.4.0 but I've filed #924 and #925, both of which I found as I was going through the app for 7.4.0-alpha.1 review.

@langsmith
Copy link
Contributor Author

langsmith commented Apr 18, 2019 •
edited
Loading

No issues with the examples on alpha.2

@langsmith langsmith requested a review from osana May 15, 2019 18:35
@langsmith langsmith added the ready for review When your PR has been personally reviewed, its time for an external contributors to approve label May 15, 2019
@langsmith langsmith force-pushed the ls-maps-sdk-7.4.0 branch from 421f027 to e30629d Compare May 16, 2019 17:51
@langsmith langsmith removed the request for review from osana May 21, 2019 23:26
@langsmith
Copy link
Contributor Author

langsmith commented May 21, 2019

Very weird CI 💥 have been popping up for me on this branch. They don't appear on master and I already re-based. So strange. nectar is going out soon anyways 😕 .

@LukasPaczos
Copy link
Contributor

LukasPaczos commented May 22, 2019

The crashes were caused by the mapbox-java version mismatch between Maps SDK and plugins. Fixed in efd2204.

@langsmith
Copy link
Contributor Author

langsmith commented May 22, 2019

Ah, ok. Thanks @LukasPaczos .

@LukasPaczos LukasPaczos merged commit f80d756 into master May 22, 2019
@LukasPaczos LukasPaczos deleted the ls-maps-sdk-7.4.0 branch May 22, 2019 14:29
@LukasPaczos LukasPaczos mentioned this pull request May 22, 2019
Merged
2 tasks
@langsmith langsmith mentioned this pull request Jun 11, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@langsmith langsmith

Labels

ready for review When your PR has been personally reviewed, its time for an external contributors to approve

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@langsmith @LukasPaczos