Removing monobehaviour injection (no longer needed).#1
Merged
david-rhodes merged 1 commit intovector2dfrom Mar 31, 2017
Merged
Conversation
Use `Runnable.Run()` for any “asynchronous” operations, rather than coroutines!
Author
|
@brnkhy Want to merge this into |
Contributor
|
@david-rhodes looks good to me. we might need to pass down another parameter down to factories later on (to be able to remove static fields, rect&scale from map controller) but that's another issue of course. |
david-rhodes
pushed a commit
that referenced
this pull request
Mar 31, 2017
* implement Vector2d, Vector3d, Mathd and RectD classes switch to double based structs for lat/lng/meter values * move Vector2 classes to sdk-cs * bumping to the proper branch for testing * removed GeometryAsWsg84 usage and converting vector tile coordinates to unity space in VectorFeatureUnity class * add missing VectorLayerVisualizer from previous commit * Adding fix for Directions request (proper string formatting for Vector2d). * fix the vector tile layer extent problem which wasn't working with traffic data * Removing monobehaviour injection (no longer needed). (#1) Use `Runnable.Run()` for any “asynchronous” operations, rather than coroutines! * Pointing back to master.
wilhelmberg
pushed a commit
that referenced
this pull request
Jun 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove monobehaviour injection from factories as we have a better way to run coroutines.