Skip to content

Cutting holes#53

Merged
david-rhodes merged 28 commits intodevelopfrom
cuttingHoles
May 16, 2017
Merged

Cutting holes#53
david-rhodes merged 28 commits intodevelopfrom
cuttingHoles

Conversation

@brnkhy
Copy link
Copy Markdown
Contributor

@brnkhy brnkhy commented May 5, 2017

@david-rhodes can you check this if/when you have time please?
This'll probably be a little hard to merge in as it's a quite big PR but would be nice if we can test&talk about it next week.

brnkhy added 11 commits April 19, 2017 02:30
remove edge subdivision (will be added as a modifier)
remove terrain snapping & min_height usage (will be added as a part of height modifier)
add height query to polygon modifier for testing (will moved out)
add snap terrain modifier
remove snaping to terrain and line subdivision from layer visualizer
add flat tops option to height modifier
remove terrain snapping from polygon modifier
add meshdata vertex snapping to snapping modifier (along with original feature point snapping, which will probably be removed in the future)
# Conflicts:
#	sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/LayerVisualizers/VectorLayerVisualizer.cs
@brnkhy brnkhy requested a review from david-rhodes May 5, 2017 21:45
@david-rhodes
Copy link
Copy Markdown

  • Not all examples updated to use new modules (Drive and Slippy are broken)
  • Snap y to zero (MapController) does not seem to be working
    • Use Boulder, Co, for MeshGeneration.unity location and you will see the tiles are too far above the ground plane to see in camera view
  • Modifiers need to have a static order (custom inspectors can even reorder as they are added)
    • We could have always benefitted from this, but now that we have even more modifiers, they need to be ordered properly (by us).
  • Roofs on terrain are still not straight:

screen shot 2017-05-08 at 2 12 03 pm

On the up side, there are zero conflicts when trying to pull develop in 👍.

@brnkhy
Copy link
Copy Markdown
Contributor Author

brnkhy commented May 15, 2017

@david-rhodes I fixed a small issue with y axis coordinates.
flat roofs should be OK now, you sure you had Flat Roof checked in height modifier?
unity_2017-05-15_17-44-52

demos might be totally broken, files are in bad/wrong folders as well. I'll polish this and get ready to merge asap.
snap y is globally broken I guess, I'll check that as well.

fix drive and slippy scenes' module links
@brnkhy
Copy link
Copy Markdown
Contributor Author

brnkhy commented May 16, 2017

@david-rhodes I fixed some scenes and module references. should be easier to review now.
I had different plans for modifier hierarchy/order but looks like it'll actually be much better if we switch to a much more restrictive system for that in short term. I have some ideas for that, let's talk whenever you have time.

David Rhodes and others added 12 commits May 16, 2017 10:08
change directions factory to create a VectorFeatureUnity for modifiers
# Conflicts:
#	sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/Data/VectorFeatureUnity.cs
#	sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/Factories/DirectionsFactory.cs
#	sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/MapController.cs
brnkhy and others added 2 commits May 16, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants