Cutting holes#53
Merged
david-rhodes merged 28 commits intodevelopfrom May 16, 2017
Merged
Conversation
remove edge subdivision (will be added as a modifier) remove terrain snapping & min_height usage (will be added as a part of height modifier)
add height query to polygon modifier for testing (will moved out)
add snap terrain modifier remove snaping to terrain and line subdivision from layer visualizer add flat tops option to height modifier
… connected start and edge vertices
remove terrain snapping from polygon modifier add meshdata vertex snapping to snapping modifier (along with original feature point snapping, which will probably be removed in the future)
# Conflicts: # sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/LayerVisualizers/VectorLayerVisualizer.cs
On the up side, there are zero conflicts when trying to pull develop in 👍. |
Contributor
Author
|
@david-rhodes I fixed a small issue with y axis coordinates. demos might be totally broken, files are in bad/wrong folders as well. I'll polish this and get ready to merge asap. |
fix drive and slippy scenes' module links
Contributor
Author
|
@david-rhodes I fixed some scenes and module references. should be easier to review now. |
change directions factory to create a VectorFeatureUnity for modifiers
# Conflicts: # sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/Data/VectorFeatureUnity.cs # sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/Factories/DirectionsFactory.cs # sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/MapController.cs
Fixed missing reference to map controller
This was referenced May 16, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


@david-rhodes can you check this if/when you have time please?
This'll probably be a little hard to merge in as it's a quite big PR but would be nice if we can test&talk about it next week.