Skip to content

Refactor HttpRequests#58

Merged
david-rhodes merged 11 commits intodevelopfrom
BergWerkGIS-refactor-http-requests
May 9, 2017
Merged

Refactor HttpRequests#58
david-rhodes merged 11 commits intodevelopfrom
BergWerkGIS-refactor-http-requests

Conversation

@wilhelmberg
Copy link
Copy Markdown

@wilhelmberg wilhelmberg commented May 9, 2017

This PR should be merged after mapbox/mapbox-sdk-cs#78 and before merging the submodule should be set to mapbox-sdk-cs@master again.

@david-rhodes
Copy link
Copy Markdown

@BergWerkGIS Does MapboxAccess.cs still need the MyRemoteCertificateValidationCallback stuff? Does the Unity HTTPRequest version (UnityWebRequest) not automatically handle support for UWP?

@wilhelmberg
Copy link
Copy Markdown
Author

Does MapboxAccess.cs still need the MyRemoteCertificateValidationCallback stuff? Does the Unity HTTPRequest version (UnityWebRequest) not automatically handle support for UWP?

@david-rhodes good catch, thanks. Yes, should not be needed anymore.
BTW: This was for making HTTPS requests work on iOS.

Copy link
Copy Markdown

@david-rhodes david-rhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS and Pixel work.

@david-rhodes david-rhodes merged commit 300aac1 into develop May 9, 2017
@david-rhodes david-rhodes deleted the BergWerkGIS-refactor-http-requests branch May 9, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants