test: is_image unit tests and sanitize_name edge cases (16 new tests)#23
Open
hai-pilgrim wants to merge 1 commit intomarksverdhei:mainfrom
Open
test: is_image unit tests and sanitize_name edge cases (16 new tests)#23hai-pilgrim wants to merge 1 commit intomarksverdhei:mainfrom
hai-pilgrim wants to merge 1 commit intomarksverdhei:mainfrom
Conversation
…sts) Sources is_image in setup_file. Adds coverage for all 8 image formats (jpg/jpeg, png, gif, bmp, tiff, svg, webp) plus negative cases (txt, html, .bin). Integration tests verify jpg/png are processed instead of skipped as binary. Three extra sanitize_name edge cases: multi-space collapsing, quote stripping, multiline input (last line wins). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_imageinsetup_filealongside existingis_binaryis_image: JPEG (jpg/jpeg), PNG, GIF, BMP, TIFF, SVG (extension fallback), WebP.binare not detected as imagessanitize_nameedge cases: multi-space/hyphen collapsing, quote stripping, multiline input uses last non-empty lineTest plan
is_binarydue to missingfilecommand in this env are unrelated)bats test.sh🤖 Generated with Claude Code