Skip to content

test: is_image unit tests and sanitize_name edge cases (16 new tests) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hai-pilgrim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: is_image unit tests and sanitize_name edge cases (16 new tests) #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 88 additions & 1 deletion test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ setup_file() {
# Source testable bash functions
eval "$(sed -n '/^sanitize_name/,/^}/p' "$HAT")"
eval "$(sed -n '/^is_binary/,/^}/p' "$HAT")"
eval "$(sed -n '/^is_image/,/^}/p' "$HAT")"
eval "$(sed -n '/^collect_metadata/,/^}/p' "$HAT")"
export -f sanitize_name is_binary collect_metadata
export -f sanitize_name is_binary is_image collect_metadata

# Start mock LLM server that handles multi-turn conversations
export MOCK_PORT=18950
Expand Down Expand Up @@ -106,6 +107,23 @@ teardown_file() {
assert_output "sunset-view.pdf"
}

# ── Sanitize name: additional edge cases ───────────────────────────

@test "sanitize: collapses multiple spaces/hyphens to single hyphen" {
run sanitize_name "my report doc" "true" "pdf"
assert_output "my-report-doc.pdf"
}

@test "sanitize: strips surrounding quotes" {
run sanitize_name '"quoted-name"' "true" "txt"
assert_output "quoted-name.txt"
}

@test "sanitize: multiline input uses last non-empty line" {
run sanitize_name $'first-line\nsecond-name' "true" "txt"
assert_output "second-name.txt"
}

# ── Binary detection ─────────────────────────────────────────────────

@test "binary: text file is not binary" {
Expand All @@ -128,6 +146,75 @@ teardown_file() {
assert_failure
}

# ── Image detection ─────────────────────────────────────────────────

@test "image: jpg is detected as image" {
run is_image "$TEST_ASSETS/sample.jpg"
assert_success
}

@test "image: jpeg is detected as image" {
run is_image "$TEST_ASSETS/sample.jpeg"
assert_success
}

@test "image: png is detected as image" {
run is_image "$TEST_ASSETS/sample.png"
assert_success
}

@test "image: gif is detected as image" {
run is_image "$TEST_ASSETS/sample.gif"
assert_success
}

@test "image: bmp is detected as image" {
run is_image "$TEST_ASSETS/sample.bmp"
assert_success
}

@test "image: tiff is detected as image" {
run is_image "$TEST_ASSETS/sample.tiff"
assert_success
}

@test "image: svg is detected as image (extension fallback)" {
run is_image "$TEST_ASSETS/sample.svg"
assert_success
}

@test "image: webp is detected as image" {
run is_image "$TEST_ASSETS/sample.webp"
assert_success
}

@test "image: text file is not an image" {
run is_image "$TEST_ASSETS/sample.txt"
assert_failure
}

@test "image: html file is not an image" {
run is_image "$TEST_ASSETS/sample.html"
assert_failure
}

@test "image: binary .bin is not an image" {
run is_image "$TEST_ASSETS/sample.bin"
assert_failure
}

# ── Image integration ─────────────────────────────────────────────────

@test "image: jpg is processed as image (not skipped as binary)" {
run bash -c "LLM_BASE_URL=http://127.0.0.1:$MOCK_PORT bash '$HAT' --quiet --dry-run --force '$TEST_ASSETS/sample.jpg' 2>/dev/null"
assert_output "suggested-name.jpg"
}

@test "image: png is processed as image (not skipped as binary)" {
run bash -c "LLM_BASE_URL=http://127.0.0.1:$MOCK_PORT bash '$HAT' --quiet --dry-run --force '$TEST_ASSETS/sample.png' 2>/dev/null"
assert_output "suggested-name.png"
}

# ── Metadata collection ─────────────────────────────────────────────

@test "metadata: text file has size and modified" {
Expand Down