test: 13 tests for segmentation module (previously uncovered)#29
Open
hai-pilgrim wants to merge 1 commit intomarksverdhei:mainfrom
Open
test: 13 tests for segmentation module (previously uncovered)#29hai-pilgrim wants to merge 1 commit intomarksverdhei:mainfrom
hai-pilgrim wants to merge 1 commit intomarksverdhei:mainfrom
Conversation
Covers generate_segment_masks (2D output/None shape, RGBA input, two-region image, no crash), show_mask (fixed vs random color, zero mask → zero overlay, 4-channel RGBA output), and make_background_transparent (tuple return, PIL image first element, debug=False → None debug image, no crash on uniform image). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spritegrid/segmentation.py, which had no existing testsgenerate_segment_masks: output shape matches input, RGBA input uses first 3 channels, two-region image doesn't crash, None returned when all noiseshow_mask: fixed color → deterministic RGB values, random_color=True produces different results on different seeds, all-zero mask → all-zero overlay, output has 4 channelsmake_background_transparent: returns 2-tuple, first element is PIL image,debug=Falsereturns None for debug image, no crash on uniform imageTest plan
uv run pytest tests/test_segmentation.py -q🤖 Generated with Claude Code