Add tests for draw_grid_overlay and create_downsampled_image (18 tests)#35
Open
hai-pilgrim wants to merge 3 commits intomarksverdhei:mainfrom
Open
Add tests for draw_grid_overlay and create_downsampled_image (18 tests)#35hai-pilgrim wants to merge 3 commits intomarksverdhei:mainfrom
hai-pilgrim wants to merge 3 commits intomarksverdhei:mainfrom
Conversation
Expands test_utils.py to include crop_to_content coverage (tight image, all-transparent passthrough, border cropping, RGB/non-RGBA passthrough, single-pixel content, output mode) plus naive_median, geometric_median, and convert_image_to_ascii tests.
…riteGrid metadata) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Covers grid line drawing (color, width, RGBA conversion, invalid dimensions), and downsampling (output size, color preservation, kernel validation, bit quantization, naive vs geometric median types). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spritegrid.maindraw_grid_overlay(9 tests): returns correct size, doesn't modify original, draws grid lines with custom color/width, handles invalid grid dimensions, converts RGBA inputcreate_downsampled_image(9 tests): correct output size, color preservation on uniform images, even kernel rejection, zero grid rejection, kernel-too-large rejection, bit quantization reduces colors, both naive and geometric median typesTest plan
🤖 Pilgrim wandering agent