Merged
Conversation
rename tr obs to obserer4msel
new argument in arg parser that is bassed to b task
…he results file. Integrated in the model selection process
…eady contained in the dictionary beeing passed to the writer
Logging the duration through an additional attribute in the experiment class
Logging epochs
…rain epoch. Reverted prior backpack changes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mhof_dev #845 +/- ##
============================================
- Coverage 95.15% 90.91% -4.24%
============================================
Files 127 137 +10
Lines 4994 5858 +864
============================================
+ Hits 4752 5326 +574
- Misses 242 532 +290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
smilesun
reviewed
Jul 2, 2024
Collaborator
There was a problem hiding this comment.
so all files in folder "data" has been moved to domainlab/zdata already?
| @@ -261,5 +261,5 @@ def test_msel_oracle4(): | |||
| ) | |||
| exp.execute(num_epochs=2) | |||
| exp.trainer.observer.model_sel.msel.best_loss = 0 | |||
| exp.trainer.observer.model_sel.msel.update(clear_counter=True) | |||
| exp.trainer.observer.model_sel.msel.update(epoch = 1, clear_counter=True) | |||
Collaborator
There was a problem hiding this comment.
epoch=1 is to save time or does not work with 2?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the functionality to avoid naming collisions to the mhof_dev branch.