Skip to content

break down Red Bank contract.rs and test.rs into smaller files#31

Merged
larry0x merged 4 commits intomasterfrom
larry/break-down-big-files
Aug 11, 2022
Merged

break down Red Bank contract.rs and test.rs into smaller files#31
larry0x merged 4 commits intomasterfrom
larry/break-down-big-files

Conversation

@larry0x
Copy link
Contributor

@larry0x larry0x commented Aug 10, 2022

for better readability

contract.rs

is broken down into:

  • contract.rs which contains the entry points
  • execute.rs which contains the execute functions
  • query.rs which contains the query functions

test.rs

is broken down into the following files according to the topics of the tests:

  • admin.rs (all owner/administrative functions)
  • borrow.rs
  • deposit.rs
  • liquidate.rs
  • misc.rs
  • query.rs
  • withdraw.rs

Copy link
Collaborator

@piobab piobab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small comments to be consistent, rest LGTM

@larry0x larry0x requested a review from piobab August 11, 2022 03:52
dancreee
dancreee previously approved these changes Aug 11, 2022
Copy link

@dancreee dancreee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice lgtm

@larry0x larry0x merged commit bf0e74f into master Aug 11, 2022
@larry0x larry0x deleted the larry/break-down-big-files branch August 11, 2022 10:49
larry0x pushed a commit that referenced this pull request Oct 7, 2023
* MP-1447. Migrate to osmosis-rust.

* MP-1447. Tests - update to new osmosis-rust.

* MP-1447. Fix tests.

* MP-1447. More tests fixed.

* Fix for denoms and price calc.

* Use TWAP for estimate.

* Use deps from github with more queries.

* Fixes after review.

* Use 1.18 go version.

* Include chain package for ci/cd.

* Bump go.

* Fix clippy.

* MP-1702. Ignore TWAP related tests.

* Use metadata and env for osmosis-testing.

* Update github ci/cd to use wasm files for testing.

* Fix clippy.

* Use wasm from cargo build outputs.

* Remove env for tests.

* Update imported package to workspace.

* Use wasm files from cargo build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants