simplify mars_outpost::red_bank exports

[larry0x]

currently the way the mars_outpost::red_bank module works is, there are some stuff defined in mod.rs, some defined in interest_rate_model.rs, some in msg.rs, and i need to know where each thing is, and import them separately from each sub-module:

use mars_outpost::red_bank::FirstThing;
use mars_outpost::red_bank::interest_rate_model::SecondThing;
use mars_outpost::red_bank::msg::ThirdThing;

this doesn't make sense to me... this PR:

• moves types defined in mod.rs to a separate types.rs file
• export types defined in sub-modules, so that all things Red Bank can be imported in a single place:

use mars_outpost::red_bank::{FirstThing, SecondThing, ThirdThing};

[dancreee]

This looks like an improvement to me - however with anything somewhat subjective I think we should

a. determine if a refactor introduces any additional bug/exploit risk
b. have all core devs align on this as a coding standard and put it in the guidelines - with the goal to remove most subjective changes from day to day PR's

@piobab thoughts on this and adding it to the guidelines

[piobab]

This looks like an improvement to me - however with anything somewhat subjective I think we should

a. determine if a refactor introduces any additional bug/exploit risk b. have all core devs align on this as a coding standard and put it in the guidelines - with the goal to remove most subjective changes from day to day PR's

@piobab thoughts on this and adding it to the guidelines

"moves types defined in mod.rs to a separate types.rs file" - OK

When it comes to re-exports, we have to remember:
Putting everything in one bag can be convenient for importing, but it removes modules with the right logic, the right types (we can't do module::function). Additionally, if the same structure or function name is used in another module, it will result in a name conflict.
For sure it will help to use by external clients (contracts).

[grod220]

I don't have a strong opinion on this. Intelliji automatically finds/imports and it also hides imports by default in every file. So the way they look is almost irrelevant to my dev workflow. My only concern would be to not make the types.rs file a monolith if they could live closer to their usage.

The base branch was changed.

[ahmadkaouk]

For me, I like to have smaller import sections and shorter paths. But this personal preference.

[larry0x]

@dancreee @piobab can you approve again? i had to resolve the conflicts after merging #31, which dismissed your previous approvals

[grod220]

I'll approve this (as I hate automatic PR approval dismissals lol)

[dancreee]

I'll approve this (as I hate automatic PR approval dismissals lol)

ok the crowd has spoken, i'll remove this