Skip to content

Apple Silicon Github-hosted runner for build-test job#508

Merged
phatblat merged 4 commits intomas-cli:mainfrom
rgoldberg:apple-silicon-github-hosted-runner
Feb 17, 2024
Merged

Apple Silicon Github-hosted runner for build-test job#508
phatblat merged 4 commits intomas-cli:mainfrom
rgoldberg:apple-silicon-github-hosted-runner

Conversation

@rgoldberg
Copy link
Member

@rgoldberg rgoldberg commented Feb 4, 2024

Apple Silicon Github-hosted runner for build-test job.

See #496 (comment)

@rgoldberg rgoldberg requested a review from a team as a code owner February 4, 2024 15:47
@GreyTeardrop
Copy link

Looks like swift-format is failing on the macos-14 runner. Their README says the latest version could be used for all Swift 5.8+ platforms.

@rgoldberg
Copy link
Member Author

@GreyTeardrop Thanks. I pushed an update. I need to fix some formatting issues in existing files. Will do so later.

@rgoldberg rgoldberg marked this pull request as draft February 5, 2024 07:58
swiftformat Sources Tests
@rgoldberg rgoldberg marked this pull request as ready for review February 5, 2024 21:07
@rgoldberg
Copy link
Member Author

rgoldberg commented Feb 5, 2024

@GreyTeardrop Passing all checks now. Can you pull my changes, then create a new PR that is exactly the same as this one? I can then approve it (I can't approve my own PR, and all the other organization members are MIA). Once approved, it will merge, then I can run the checks for #496, then approve that, then look into how to release a new version.

@GreyTeardrop
Copy link

@rgoldberg Will do now

@GreyTeardrop
Copy link

Opened #509

@phatblat phatblat merged commit ec503a1 into mas-cli:main Feb 17, 2024
@rgoldberg rgoldberg deleted the apple-silicon-github-hosted-runner branch February 18, 2024 03:27
@rgoldberg rgoldberg added this to the 1.8.7 milestone May 15, 2025
@rgoldberg rgoldberg self-assigned this May 15, 2025
@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧽 chore Administrative task: documentation, build, test, release, git, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants