Skip to content

Apple silicon GitHub hosted runner#509

Merged
phatblat merged 4 commits intomas-cli:mainfrom
GreyTeardrop:apple-silicon-github-hosted-runner
Feb 17, 2024
Merged

Apple silicon GitHub hosted runner#509
phatblat merged 4 commits intomas-cli:mainfrom
GreyTeardrop:apple-silicon-github-hosted-runner

Conversation

@GreyTeardrop
Copy link

@GreyTeardrop GreyTeardrop commented Feb 5, 2024

Pulling @rgoldberg changes from #508.

@GreyTeardrop GreyTeardrop requested a review from a team as a code owner February 5, 2024 22:57
@GreyTeardrop GreyTeardrop mentioned this pull request Feb 5, 2024
Merged
@GreyTeardrop
Copy link
Author

GreyTeardrop commented Feb 5, 2024

@rgoldberg the workflow is paused and needs an approval.

@rgoldberg
Copy link
Member

rgoldberg commented Feb 5, 2024

@GreyTeardrop Thanks. Approved. Check running now.

@rgoldberg rgoldberg requested review from rgoldberg and removed request for rgoldberg February 5, 2024 23:42
@rgoldberg
Copy link
Member

rgoldberg commented Feb 5, 2024 •
edited
Loading

@GreyTeardrop Can you request that I review this PR?

I already approved, but that only ran the checks, which all passed, but merging is still blocked. Either mas-cli/admins must approve to merge, or you need to request a review from me, then I need to approve it. I assume the former is the case, but it won't hurt to try a review request from you to me.

@GreyTeardrop
Copy link
Author

GreyTeardrop commented Feb 5, 2024

Nope, I don't have an option to request any review :-(

@rgoldberg
Copy link
Member

rgoldberg commented Feb 5, 2024

@GreyTeardrop Sorry, didn't know you wouldn't be able to request a review. I self-requested, but didn't see an option to approve the self-request. I'll try to get more permissions…

phatblat
phatblat reviewed Feb 17, 2024
View reviewed changes
Copy link
Member

@phatblat phatblat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks, @GreyTeardrop

@phatblat phatblat merged commit ec503a1 into mas-cli:main Feb 17, 2024
@GreyTeardrop GreyTeardrop deleted the apple-silicon-github-hosted-runner branch February 17, 2024 18:05
@phatblat phatblat mentioned this pull request Feb 18, 2024
Merged
@rgoldberg rgoldberg self-assigned this May 15, 2025
@rgoldberg rgoldberg added this to the 1.8.7 milestone May 15, 2025
@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phatblat phatblat phatblat approved these changes

Assignees

@rgoldberg rgoldberg

Labels

🧽 chore Administrative task: documentation, build, test, release, git, etc.

Projects

None yet

Milestone

1.8.7

Development

Successfully merging this pull request may close these issues.

3 participants

@GreyTeardrop @rgoldberg @phatblat