Remove msc build tags. Add msc packages.#666
Merged
Merged
Conversation
This adds more parallelism as a side-effect.
DMRobertson
reviewed
Oct 10, 2023
Contributor
DMRobertson
left a comment
DMRobertson
left a comment
There was a problem hiding this comment.
Is this going to need changes to https://github.com/matrix-org/synapse/blob/6d81aec09febe86532235141e84c4ea0b3f56049/scripts-dev/complement.sh#L217? Are there other places in Synapse we'll need to change? Similarly for dendrite
Member
Author
|
Yes. |
DMRobertson
approved these changes
Oct 11, 2023
Contributor
DMRobertson
left a comment
DMRobertson
left a comment
There was a problem hiding this comment.
LGTM but it'd be very handy if you can do the Synapse+Dendrite changes too. (Though FWIW Synapse's develop is failing on particular complement test RN)
kegsay
added a commit
to matrix-org/synapse
that referenced
this pull request
Oct 11, 2023
4 tasks
kegsay
added a commit
to matrix-org/dendrite
that referenced
this pull request
Oct 11, 2023
This was referenced Oct 11, 2023
devonh
approved these changes
Oct 11, 2023
kegsay
added a commit
to matrix-org/dendrite
that referenced
this pull request
Oct 11, 2023
kegsay
added a commit
to matrix-org/synapse
that referenced
this pull request
Oct 12, 2023
* Update complement.sh to match new public API shape Sister PR to matrix-org/complement#666 Context: matrix-org/complement#654 (comment) * Changelog * Pedantry * Run complement plz
anoadragon453
added a commit
that referenced
this pull request
Jun 3, 2025
We no longer use them as of #666
1 task
kegsay
pushed a commit
that referenced
this pull request
Jun 6, 2025
* Remove documentation surrounding MSC build tags We no longer use them as of #666 * Document test writing for unstable MSCs * Add currently-known blacklist tags So those adding new tests know what to blacklist out of the box.
jevolk
pushed a commit
to matrix-construct/complement
that referenced
this pull request
Jul 22, 2025
) * Remove documentation surrounding MSC build tags We no longer use them as of matrix-org#666 * Document test writing for unstable MSCs * Add currently-known blacklist tags So those adding new tests know what to blacklist out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more parallelism as a side-effect.