This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Update complement.sh to match new public API shape#16466
Merged
Conversation
Contributor
|
Try adding the complement.sh script in synapse/.github/workflows/tests.yml Lines 50 to 58 in a6abee3 |
Member
Author
|
It runs now, and fails the same failing tests on |
DMRobertson
reviewed
Oct 11, 2023
DMRobertson
reviewed
Oct 11, 2023
DMRobertson
approved these changes
Oct 11, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Otherwise LGTM, thanks! I'll let you merge in tandem with the complement and Dendrite change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sister PR to matrix-org/complement#666
Context: matrix-org/complement#654 (comment)
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)